Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.4.0 PR - Convert workload modules to classes #856

Merged
merged 1 commit into from
Jun 16, 2020
Merged

0.4.0 PR - Convert workload modules to classes #856

merged 1 commit into from
Jun 16, 2020

Conversation

aklenik
Copy link
Contributor

@aklenik aklenik commented Jun 4, 2020 •
edited
Loading

  • Create interface and base class for workload modules
  • Load workload modules with the factory approach
  • Update CI test workloads to class format
  • Extend CI workload arguments where needed to make workloads deterministic
  • Increase frequency of TX updates in CI tests to increase monitor accuracy
  • Update workload module paths in the benchconfig files to precise relative path
  • Create separate artifacts for Fabric v2 CI phase

Closes #576

Signed-off-by: Attila Klenik [email protected]

Note: the generator integration test is broken currently, but maybe we should wait for the next workload module updates before adjusting it.

Docs update and benchmark repo update WIP.

@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request introduces 3 alerts and fixes 2 when merging e2fb82d into d0507aa - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Insecure randomness

@aklenik aklenik force-pushed the workload-module-to-class branch from e2fb82d to bd84a29 Compare June 4, 2020 18:00
@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request fixes 2 alerts when merging bd84a29 into d0507aa - view on LGTM.com

fixed alerts:

  • 2 for Insecure randomness

@aklenik aklenik force-pushed the workload-module-to-class branch from bd84a29 to a5023d4 Compare June 4, 2020 19:32
@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request fixes 2 alerts when merging a5023d4 into d0507aa - view on LGTM.com

fixed alerts:

  • 2 for Insecure randomness

@aklenik aklenik force-pushed the workload-module-to-class branch from a5023d4 to b61c2fc Compare June 4, 2020 21:35
@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2020

This pull request fixes 2 alerts when merging b61c2fc into d0507aa - view on LGTM.com

fixed alerts:

  • 2 for Insecure randomness

@aklenik
Copy link
Contributor Author

aklenik commented Jun 4, 2020

@benjamincburns I've updated the ethereum and besu bindings to use [email protected], since 1.2.0 doesn't seem to contain the getChainId function (#838).
I've also updated the packages/caliper-tests-integration/besu_tests/config/docker-compose.yml file to enable ws connections.

Could you please take a look at the ethereum-related changes? There still seems to be some nonce/gas? related errors for the ethereum CI test (besu runs fine): https://travis-ci.com/github/hyperledger/caliper/jobs/343851469#L661

@nklincoln nklincoln changed the title Convert workload modules to classes 0.4.0 PR - Convert workload modules to classes Jun 10, 2020
@aklenik
Convert workload modules to classes
ec51503 
- Create interface and base class for workload modules
- Load workload modules with the factory approach
- Update CI test workloads to class format
- Extend CI workload arguments where needed to make workloads deterministic
- Increase frequency of TX updates in CI tests to increase monitor accuracy
- Update workload module paths in the benchconfig files to precise relative path
- Create separate artifacts for Fabric v2 CI phase

Signed-off-by: Attila Klenik <[email protected]>
@aklenik aklenik force-pushed the workload-module-to-class branch from b61c2fc to ec51503 Compare June 16, 2020 10:35
@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2020

This pull request fixes 2 alerts when merging ec51503 into f7b17a9 - view on LGTM.com

fixed alerts:

  • 2 for Insecure randomness

@nklincoln nklincoln self-assigned this Jun 16, 2020
nklincoln
nklincoln approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@nklincoln nklincoln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@aklenik aklenik merged commit 8041954 into hyperledger-caliper:master Jun 16, 2020
@aklenik aklenik deleted the workload-module-to-class branch June 24, 2020 12:37
@aklenik aklenik mentioned this pull request Jun 24, 2020
Closed
@lynn14m lynn14m mentioned this pull request Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nklincoln nklincoln nklincoln approved these changes

Assignees

@nklincoln nklincoln

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Test Callbacks To Classes
2 participants
@aklenik @nklincoln